Michael Ho has posted comments on this change. Change subject: IMPALA-3629: Codegen TransferScratchTuples() in hdfs-parquet-scanner ......................................................................
Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/3774/7/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: PS7, Line 162: if (scan_node_->runtime_state()->codegen_enabled()) { Is this check redundant as GetCodegenFn() should return NULL if codegen is disabled, right ? PS7, Line 585: int tuple_byte_size, bool has_filters Did you mean to use these to replace some constants ? They don't seem to be used. http://gerrit.cloudera.org:8080/#/c/3774/7/be/src/exec/hdfs-scanner.cc File be/src/exec/hdfs-scanner.cc: PS7, Line 558: *write_complete_tuple_fn = codegen->FinalizeFunction(fn); : return Status::OK(); Doesn't this trigger the DCHECK in some code which check the returned function is not NULL if status.ok() ? In theory, FinalizeFunction() can return NULL if there is any error. http://gerrit.cloudera.org:8080/#/c/3774/7/be/src/exec/hdfs-sequence-scanner.cc File be/src/exec/hdfs-sequence-scanner.cc: PS7, Line 63: nit: wrong indentation http://gerrit.cloudera.org:8080/#/c/3774/7/be/src/exec/hdfs-text-scanner.cc File be/src/exec/hdfs-text-scanner.cc: PS7, Line 699: DCHECK(*write_aligned_tuples_fn != NULL); Please see comments in CodegenWriteAlignedTuples() about this DCHECK(). -- To view, visit http://gerrit.cloudera.org:8080/3774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic327e437c7cd2b3f92cdb11c1e907bfee2d44ee8 Gerrit-PatchSet: 7 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
