Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3629: Codegen TransferScratchTuples() in hdfs-parquet-scanner ......................................................................
Patch Set 8: (6 comments) http://gerrit.cloudera.org:8080/#/c/3774/8/be/src/exec/hdfs-avro-scanner.cc File be/src/exec/hdfs-avro-scanner.cc: PS8, Line 1022: Function* fn = : codegen->GetFunction(IRFunction::DECODE_AVRO_DATA, true); 1 line PS8, Line 1025: int replaced = codegen->ReplaceCallSites(fn, materialize_tuple_fn, : "MaterializeTuple"); 1 line PS8, Line 1033: replaced = codegen->ReplaceCallSites(fn, eval_conjuncts_fn, : "EvalConjuncts"); 1 line http://gerrit.cloudera.org:8080/#/c/3774/8/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: PS8, Line 582: (HdfsScanNode* node, : const vector<ExprContext*>& conjunct_ctxs, : llvm::Function** process_scratch_batch_fn can some of these lines be combined? PS8, Line 592: : llvm::Function* fn = : codegen->GetFunction(IRFunction::PROCESS_SCRATCH_BATCH, true); 1l PS8, Line 601: : int replaced = codegen->ReplaceCallSites(fn, eval_conjuncts_fn, : "EvalConjuncts"); 1 -- To view, visit http://gerrit.cloudera.org:8080/3774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic327e437c7cd2b3f92cdb11c1e907bfee2d44ee8 Gerrit-PatchSet: 8 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
