Michael Ho has posted comments on this change. Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures ......................................................................
Patch Set 1: (1 comment) Most likely not MEM_LIMIT_EXCEEDED as we would have returned from GetNextInternal() or ProcessSplit(). I tried digging through the parse_status_ and scan_node_->status_ in the core but neither shows anything. So,the error message may not have been flushed to the log file yet ? I am thinking of adding a debug action in the loop but it's probably worth looking into whether we can use the fuzzer to induce the error. http://gerrit.cloudera.org:8080/#/c/3991/1/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 512: scratch_batch_->num_tuples)); Need the same error handling in this path. -- To view, visit http://gerrit.cloudera.org:8080/3991 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1e27a1517d09ccaabdae1492b7e1fbf661ae3e5 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
