Michael Ho has posted comments on this change. Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/3991/1/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 343: context_->ClearStreams(); > We can also ask Alex about it, I believe he wrote this code. I believe it's always safe to do the two lines above even if advance_row_group_ == true. Line 373: if (context_->cancelled()) return Status::CANCELLED; > In case of parse error in AssembleRows(), we may not have called CommitRows Removed. If the scanner doesn't see the cancellation here, it's bound to see it at some point in CommitRows() if keeps producing row batches. Line 512: scratch_batch_->num_tuples)); > Need the same error handling in this path. Done Line 513: *skip_row_group = true; > Yes, missed that after rebase. Done -- To view, visit http://gerrit.cloudera.org:8080/3991 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1e27a1517d09ccaabdae1492b7e1fbf661ae3e5 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-HasComments: Yes
