Michael Ho has posted comments on this change. Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures ......................................................................
Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/3991/3/be/src/exec/exec-node.cc File be/src/exec/exec-node.cc: PS3, Line 441: Status::MemLimitExceeded(); > shoudl this use mem_tracker()->SetMemLimitExceeded() since Tim is convertin Done http://gerrit.cloudera.org:8080/#/c/3991/3/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: PS3, Line 350: column_readers_[0]->RowGroupAtEnd() > couldn't we have hit column 0's end of rowgroup, but not column 1's, which Good point. Reverted to the check in the old code. http://gerrit.cloudera.org:8080/#/c/3991/3/be/src/exec/hdfs-scanner.h File be/src/exec/hdfs-scanner.h: PS3, Line 381: current > currently Done PS3, Line 383: nodes > node's Done -- To view, visit http://gerrit.cloudera.org:8080/3991 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1e27a1517d09ccaabdae1492b7e1fbf661ae3e5 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-HasComments: Yes
