Dan Hecht has posted comments on this change. Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures ......................................................................
Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/3991/3/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: PS3, Line 350: column_readers_[0]->RowGroupAtEnd() couldn't we have hit column 0's end of rowgroup, but not column 1's, which would then lead to advance_row_group_ == true. Should we skip this validation in that case (like the old code since this validation error would be secondary to the one that we hit during column 1)? http://gerrit.cloudera.org:8080/#/c/3991/3/be/src/exec/hdfs-scanner.h File be/src/exec/hdfs-scanner.h: PS3, Line 381: current currently PS3, Line 383: nodes node's http://gerrit.cloudera.org:8080/#/c/3991/3/be/src/exec/parquet-column-readers.cc File be/src/exec/parquet-column-readers.cc: Line 61: #define SHOULD_TRIGGER_DEBUG_ACTION(x) ((x & DEBUG_ACTION_TRIGGER) == 0) you don't have to do it now but it would be nice to build this kind of logic into the DebugAction code itself eventually. -- To view, visit http://gerrit.cloudera.org:8080/3991 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1e27a1517d09ccaabdae1492b7e1fbf661ae3e5 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
