Tim Armstrong has posted comments on this change. Change subject: IMPALA-3943: Adhere to abort_on_error in ProcessFooter(). ......................................................................
Patch Set 7: (1 comment) Not this patch, but we should consider changing HdfsScanNode so that it handles the abort_on_error logic at the callsite for Open() if Open() fails. It might simplify this and the other scanners http://gerrit.cloudera.org:8080/#/c/3862/7/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 188: if (!status.ok()) return state_->LogOrReturnError(status.msg()); Don't we want to return early if there was any kind of error? If its a non-aborting error I think we want to return early with Status::OK(), since it's not clear if it's safe to execute the below code. -- To view, visit http://gerrit.cloudera.org:8080/3862 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6aff766a1ce6376efb329bdde51c648149dfe08c Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
