Dan Hecht has posted comments on this change. Change subject: IMPALA-3943: Adhere to abort_on_error in ProcessFooter(). ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/3862/5/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: PS5, Line 183: if (!status.ok()) return state_->LogOrReturnError(status.msg()) > I maintain this will work, and I did run through these paths on ASAN. My concern was if we get far enough to set the file metadata but it fails validation, e.g. CreateSchemaTree() fails. Isn't that a problem? In any case, I'll try to find time tomorrow to see why this has started failing recently since the code doesn't seem to have actually regressed yet those files were around for a while (how do you know that? are you sure data wasn't regenerated recently?). -- To view, visit http://gerrit.cloudera.org:8080/3862 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6aff766a1ce6376efb329bdde51c648149dfe08c Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
