Dan Hecht has posted comments on this change. Change subject: IMPALA-3943: Adhere to abort_on_error in ProcessFooter(). ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/3862/5/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: PS5, Line 183: if (!status.ok()) return state_->LogOrReturnError(status.msg()) > CreateSchemaTree() is done in the schema resolver on L186 which we would no Oops, I was looking at an older version of the code. The problem is still possible if e.g. file_metadata_.num_rows < 0. As much as I dislike adding more state, I do think we need a flag. It's too fragile otherwise, especially with special case paths like IsZeroSlotTableScan() which won't care about the presence of row-groups. -- To view, visit http://gerrit.cloudera.org:8080/3862 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6aff766a1ce6376efb329bdde51c648149dfe08c Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
