Michael Ho has posted comments on this change. Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/3991/4/be/src/exec/exec-node.cc File be/src/exec/exec-node.cc: Line 442: "Debug Action: MEM_LIMIT_EXCEEDED"); > this is fine with me, but any reason we don't use mem_tracker() (i.e. exec- Done http://gerrit.cloudera.org:8080/#/c/3991/4/be/src/exec/hdfs-scan-node.h File be/src/exec/hdfs-scan-node.h: PS4, Line 576: if requested by scanner > I think we should delete this part because it sounds like the function itse Done -- To view, visit http://gerrit.cloudera.org:8080/3991 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1e27a1517d09ccaabdae1492b7e1fbf661ae3e5 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
