Michael Ho has posted comments on this change. Change subject: IMPALA-4006 impala-config.sh contains dangerous rm -rf statements ......................................................................
Patch Set 1: (12 comments) Thanks for cleaning things up. Not sure if there is a easier way to fix this other than adding quote everywhere ? http://gerrit.cloudera.org:8080/#/c/4078/1/bin/clean.sh File bin/clean.sh: PS1, Line 49: $IMPALA_ALL_LOGS_DIRS Won't this line suffer from the same problem ? PS1, Line 53: pushd $IMPALA_HOME/be Same problem ? PS1, Line 59: pushd $IMPALA_HOME/shell Same problem ? PS1, Line 71: rm -f $IMPALA_HOME/llvm-ir/impala*.ll : rm -f $IMPALA_HOME/be/generated-sources/impala-ir/* Are these lines also unsafe ? http://gerrit.cloudera.org:8080/#/c/4078/1/bin/run-all-tests.sh File bin/run-all-tests.sh: PS1, Line 101: LOG_DIR="${IMPALA_EE_TEST_LOGS_DIR}" Is this variable still used ? PS1, Line 137: ${IMPALA_HOME} Same problem ? PS1, Line 173: {IMPALA_EE_TEST_LOGS_DIR} Same problem ? PS1, Line 173: ${IMPALA_HOME}/ Same problem ? PS1, Line 196: ${IMPALA_HOME} Same. http://gerrit.cloudera.org:8080/#/c/4078/1/buildall.sh File buildall.sh: Line 248: "$IMPALA_HOME/bin/clean.sh" Feel free to ignore but it should be sufficient to just have the quote around ${IMPALA_HOME}. Same for other places in the file. PS1, Line 321: $IMPALA_LZO Same problem ? PS1, Line 323: $IMPALA_LZO Same problem ? -- To view, visit http://gerrit.cloudera.org:8080/4078 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7503794180dee99eeb979e67f34e3b2edade70fe Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zoltan Ivanfi <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
