Tim Armstrong has posted comments on this change. Change subject: IMPALA-4006: impala-config.sh contains dangerous rm -rf statements ......................................................................
Patch Set 2: (2 comments) Mostly looks good (aside from LOG_DIR that needs to be added back in). It's an unfortunate feature of bash that we need to do this, but I'm not aware of a better practice. I believe you can avoid the spaces-in-lists-of-files problems using bash arrays but I don't know if it's worth the effort - even if we got it working it would probably get broken easily since we don't test it. http://gerrit.cloudera.org:8080/#/c/4078/1/bin/clean.sh File bin/clean.sh: PS1, Line 49: $IMPALA_ALL_LOGS_DIRS > Yes and no. On one hand, this is supposed to contain multiple log, so havin Ah got it. http://gerrit.cloudera.org:8080/#/c/4078/1/bin/run-all-tests.sh File bin/run-all-tests.sh: PS1, Line 101: ulimit -c unlimited > Done It's used by run-step -- To view, visit http://gerrit.cloudera.org:8080/4078 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7503794180dee99eeb979e67f34e3b2edade70fe Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zoltan Ivanfi <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Ivanfi <[email protected]> Gerrit-HasComments: Yes
