Michael Ho has posted comments on this change. Change subject: IMPALA-4006: dangerous rm -rf statements in scripts ......................................................................
Patch Set 3: (5 comments) It appears that you are already fixing some of the places which are considered "non-dangerous". Can you please just bite the bullet and fix up the rest pointed out below ? http://gerrit.cloudera.org:8080/#/c/4078/3/bin/impala-config.sh File bin/impala-config.sh: PS3, Line 45: $IMPALA_HOME/toolchain missing quote ? http://gerrit.cloudera.org:8080/#/c/4078/3/bin/run-all-tests.sh File bin/run-all-tests.sh: PS3, Line 111: ${IMPALA_HOME}/testdata/bin/split-hbase.sh missing quote ? PS3, Line 137: ${IMPALA_HOME}/bin/run-workload.py missing quote ? PS3, Line 173: ${IMPALA_HOME}/bin/start-impala-cluster.py missing quote ? PS3, Line 177: ${IMPALA_HOME}/bin/mvn-quiet.sh missing quote ? -- To view, visit http://gerrit.cloudera.org:8080/4078 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7503794180dee99eeb979e67f34e3b2edade70fe Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zoltan Ivanfi <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Ivanfi <[email protected]> Gerrit-HasComments: Yes
