Zoltan Ivanfi has posted comments on this change. Change subject: IMPALA-4006: impala-config.sh contains dangerous rm -rf statements ......................................................................
Patch Set 1: > (13 comments) > > This seems like a good practice, but I'm not clear on how you > decided on whether to use quotes or not, it seems like either you > missed some places or I'm not understanding the criteria used. I > pointed out a few places but not all where this was the case. Can > you clarify and then I'll do another pass. I mainly wanted to fix the rm command invocations that are the most dangerous. I fixed some other issues that I noticed but I didn't aim to address all questionable contructs as there are too many of them and some are not trivial to fix. None of these issues pose a threat to any data stored in HDFS. -- To view, visit http://gerrit.cloudera.org:8080/4078 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7503794180dee99eeb979e67f34e3b2edade70fe Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zoltan Ivanfi <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Ivanfi <[email protected]> Gerrit-HasComments: No
