Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4066/4/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: PS4, Line 474: filter_mem_tracker_ An issue here is that if there exists a coordinator fragment, this filter_mem_tracker_ will be the child of the Coordinator::executor_->runtime_state()->query_mem_tracker(), which will be destroyed before this filter_mem_tracker_ is destroyed, which could be the source of some problems. Should we just make the filter_mem_tracker_ the child of the process mem tracker? Since it doesn't belong to any single query anyway. -- To view, visit http://gerrit.cloudera.org:8080/4066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c52c8a1c2e79ef370c77bf264885fc859678d1b Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
