segelyang has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4186

Change subject: IMPALA-3308: Get expr-test passing on PPC64LE
......................................................................

IMPALA-3308: Get expr-test passing on PPC64LE

When using gcc 5+ (which introduced a new library ABI that includes new 
implementations of std::string) to
build Impala, the copy of the class ExprValue(std::string) would be unsafe as 
string_val.ptr will not be
updated to point to the relocated string_data.data().

In order to solve this issue, we need to change how we initialize value_ so 
that initialized in-place, rather
than created as a temporary on the stack then copied.

Change-Id: I4504ee6a52a085f530aadfcfa009bacb83c64787
---
M be/src/exprs/literal.cc
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/4186/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4186
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4504ee6a52a085f530aadfcfa009bacb83c64787
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: segelyang <[email protected]>

Reply via email to