segelyang has posted comments on this change. Change subject: IMPALA-3308: Get expr-test passing on PPC64LE ......................................................................
Patch Set 2: Thanks for reviewing. I used to add ExprValue::Init to solve the issue. But it makes less changes by using placement new. As I was working on PPC64le platform with old version Impala code, I was not sure what would happen on X86 platform with the latest Impala code if I added Init function. I will try to setup an X86 environment and make changes as you commented. -- To view, visit http://gerrit.cloudera.org:8080/4186 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4504ee6a52a085f530aadfcfa009bacb83c64787 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: segelyang <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: segelyang <[email protected]> Gerrit-HasComments: No
