Lars Volker has posted comments on this change. Change subject: IMPALA-3308: Get expr-test passing on PPC64LE ......................................................................
Patch Set 1: (3 comments) Thank you for your change. I added a few small comments. http://gerrit.cloudera.org:8080/#/c/4186/1//COMMIT_MSG Commit Message: Line 8: Please wrap the commit message lines at 72 characters. It makes it much easier to read in the gerrit UI. Line 13: In order to solve this issue, we need to change how we initialize value_ so that initialized in-place, rather nit: "so that it is initialized" Line 14: than created as a temporary on the stack then copied. nit: "stack and then" -- To view, visit http://gerrit.cloudera.org:8080/4186 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4504ee6a52a085f530aadfcfa009bacb83c64787 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: segelyang <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-HasComments: Yes
