Tim Armstrong has posted comments on this change. Change subject: IMPALA-3308: Get expr-test passing on PPC64LE ......................................................................
Patch Set 1: * from what I can see only the ExprValue() and ExprValue(std::string&) constructors are used anywhere so maybe we just need: ExprValue() <- Default constructor ExprValue::Init(const std::string&) <- in-place string initialiser You can delete the other constructors if they're indeed dead code. -- To view, visit http://gerrit.cloudera.org:8080/4186 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4504ee6a52a085f530aadfcfa009bacb83c64787 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: segelyang <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
