Michael Brown has posted comments on this change. Change subject: IMPALA-4047: DO NOT SUBMIT Highlight all occurrences of CDH/cdh ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4187/1/infra/deploy/deploy.py File infra/deploy/deploy.py: > This whole file is CM specific. I don't know what to do with it. My vote is to move it to a Cloudera-internal repo (Impala-aux) after ensuring there are no automated users/callers. http://gerrit.cloudera.org:8080/#/c/4187/1/tests/comparison/cluster.py File tests/comparison/cluster.py: PS1, Line 30: from cm_api.api_client import ApiResource as CmApiResource What do we do about cm_api? It's imported in a few places and part of infra/python/deps/requirements.txt https://pypi.python.org/pypi/cm-api http://gerrit.cloudera.org:8080/#/c/4187/1/tests/comparison/leopard/impala_docker_env.py File tests/comparison/leopard/impala_docker_env.py: PS1, Line 34: : > None of this would work outside of cloudera networks, what to do with it? I remembered there is a public Docker image here https://hub.docker.com/r/cloudera/impala-dev/ . It's not clear whether we could update the image to use the public one and have that in ASF, and it's not clear whether Cloudera is permitted to publish a Docker image of Impala anymore. -- To view, visit http://gerrit.cloudera.org:8080/4187 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb37e2ef0cd9fa0e581d359c5dd3db7812b7b2c8 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
