Jim Apple has posted comments on this change. Change subject: IMPALA-4047: DO NOT SUBMIT Highlight all occurrences of CDH/cdh ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4187/1/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: > Should we consider this file covered by IMPALA-3827, or should I open an ow I think it deserves it's own issue, probably. http://gerrit.cloudera.org:8080/#/c/4187/1/fe/pom.xml File fe/pom.xml: Line 198 > Isn't java-cup the parser generator we use to process /fe/src/main/cup/sql- Yeah, but why CZT? Are they bound up together, somehow? http://gerrit.cloudera.org:8080/#/c/4187/1/tests/comparison/leopard/impala_docker_env.py File tests/comparison/leopard/impala_docker_env.py: PS1, Line 34: : > Done. I also changed DEFAULT_BRANCH_NAME to 'asf-gerrit/master'. Is origin the p2a script expects asf-gerrit -- To view, visit http://gerrit.cloudera.org:8080/4187 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb37e2ef0cd9fa0e581d359c5dd3db7812b7b2c8 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
