Jim Apple has posted comments on this change. Change subject: IMPALA-4047: DO NOT SUBMIT Highlight all occurrences of CDH/cdh ......................................................................
Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/4187/1/be/src/scheduling/simple-scheduler.h File be/src/scheduling/simple-scheduler.h: Line 59 > How about removing "CDH6" and replacing it with (incompatible change) or "Impala 3.0" http://gerrit.cloudera.org:8080/#/c/4187/1/be/src/util/debug-util-test.cc File be/src/util/debug-util-test.cc: Line 64 > Afaik it should be fine to leave this. Having tests for CM integration seem agreed http://gerrit.cloudera.org:8080/#/c/4187/1/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: > Imo we should leave it for the time being. We are still depending on CDH ve See also: https://issues.cloudera.org/browse/IMPALA-3827 , "Ensure that non-CDH Hadoop components work with build&test" http://gerrit.cloudera.org:8080/#/c/4187/1/bin/save-version.sh File bin/save-version.sh: Line 24 Harrison might have thoughts on this http://gerrit.cloudera.org:8080/#/c/4187/1/ext-data-source/api/pom.xml File ext-data-source/api/pom.xml: Line 38 > these will need to stay for the time being Why is that? http://gerrit.cloudera.org:8080/#/c/4187/1/fe/pom.xml File fe/pom.xml: Line 198 > external dependency, keep What is this even used for? http://gerrit.cloudera.org:8080/#/c/4187/1/testdata/cluster/admin File testdata/cluster/admin: > Another cdh specific file. What are we going to do with it? administering a local hdfs+yarn+llama seems general purpose to me, nut CDH specific. What do you think? http://gerrit.cloudera.org:8080/#/c/4187/1/tests/comparison/leopard/impala_docker_env.py File tests/comparison/leopard/impala_docker_env.py: PS1, Line 34: : > I remembered there is a public Docker image here https://hub.docker.com/r/c I do not believe there is anything in the apache license that prevents anyone from publishing docker images. -- To view, visit http://gerrit.cloudera.org:8080/4187 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb37e2ef0cd9fa0e581d359c5dd3db7812b7b2c8 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
