Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4047: DO NOT SUBMIT Highlight all occurrences of CDH/cdh ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4187/1/common/thrift/generate_metrics.py File common/thrift/generate_metrics.py: PS1, Line 49: parser.add_option("--output_mdl_version", dest="output_mdl_version", : metavar="IMPALA_VERSION", default="2.5.0-xxx5", : help="The Impala version that is written in the output mdl.") 'mdl' is CM-specific (this and a bunch of the stuff later in the script) It's kind of used to help CM with our metrics, but we never got all the plumbing in place. I'm going to ping the CM team and find out if they're still supporting this stuff and if we should bother trying to save it. If so, then we should probably factor out this stuff into the aux repo. -- To view, visit http://gerrit.cloudera.org:8080/4187 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb37e2ef0cd9fa0e581d359c5dd3db7812b7b2c8 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
