Youwei Wang has posted comments on this change. Change subject: IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned. ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4205/3/be/src/util/bit-util.cc File be/src/util/bit-util.cc: Line 161: _mm_storeu_si128(reinterpret_cast<__m128i*>(dst + 16), part1); > What's the perf impact? I assume we still benefit from specializing this r Greetings All. @Dan I have conducted the performance test using bswap-benchmark. There is no performance loss comparing the Impala-2809. And even I got slight performance improvement using these new code. (_mm_storeu_si128/_mm_loadu_si128) -- To view, visit http://gerrit.cloudera.org:8080/4205 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39b2b47bb717d5ac9727512a24fcf8a8a6a8dcc6 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Youwei Wang <[email protected]> Gerrit-HasComments: Yes
