Dan Hecht has posted comments on this change. Change subject: IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned. ......................................................................
Patch Set 5: How about adding an end-to-end case in expr.test (or somewhere) especially since this bug is more about how the environment is set up when invoking the routine so would be good to exercise it in the real environment (as opposed to the routine semantics). -- To view, visit http://gerrit.cloudera.org:8080/4205 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39b2b47bb717d5ac9727512a24fcf8a8a6a8dcc6 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Youwei Wang <[email protected]> Gerrit-HasComments: No
