Dan Hecht has posted comments on this change. Change subject: IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned. ......................................................................
Patch Set 5: Clearly we were missing some basic test coverage. Do we have any other test gaps around this code? -- To view, visit http://gerrit.cloudera.org:8080/4205 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39b2b47bb717d5ac9727512a24fcf8a8a6a8dcc6 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Youwei Wang <youwei.a.w...@intel.com> Gerrit-HasComments: No