Michael Brown has posted comments on this change. Change subject: IMPALA-4047: DO NOT SUBMIT Highlight all occurrences of CDH/cdh ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4187/1/infra/deploy/deploy.py File infra/deploy/deploy.py: > Opened https://jira.cloudera.com/browse/CDH-44005 to track this. mikeb, do Taken. http://gerrit.cloudera.org:8080/#/c/4187/1/tests/comparison/leopard/impala_docker_env.py File tests/comparison/leopard/impala_docker_env.py: PS1, Line 34: : > Done. I also changed DEFAULT_BRANCH_NAME to 'asf-gerrit/master'. Is origin 1. If there's nothing wrong with Cloudera producing an Impala Docker image, there should be nothing wrong with the fact that its default branch is still cdh5-trunk and based off Cloudera Impala. I say leave the default branch alone. 2. origin is the correct remote name for now. See above. Now, if these are wrong politically, a separate task needs to be made to change out the Docker image is generated and published. -- To view, visit http://gerrit.cloudera.org:8080/4187 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb37e2ef0cd9fa0e581d359c5dd3db7812b7b2c8 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
