Michael Ho has posted comments on this change. Change subject: IMPALA-4008: don't bake in hash table and hash join pointers ......................................................................
Patch Set 2: (12 comments) http://gerrit.cloudera.org:8080/#/c/4326/2/be/src/exec/hash-table.cc File be/src/exec/hash-table.cc: Line 185: uint32_t HashTableCtx::HashVariableLenRow( nit: this new line seems to make the formatting a bit inconsistent with say line 163. Same for other places in this file. PS2, Line 317: uint8_t* const uint8_t* PS2, Line 322: ExprValueNullPtr( This function seems to have only one caller (ExprValueNull()) left. I find the asymmetry between ExprValuePtr() and ExprValueNullPtr() misleading. How about inlining the logic directly into the only caller ? Line 967: return Status( Wondering why the extra new line here ? http://gerrit.cloudera.org:8080/#/c/4326/2/be/src/exec/hash-table.h File be/src/exec/hash-table.h: Line 158: return expr_values_cache_.ExprValuePtr(expr_values_cache_.cur_expr_values(), expr_idx); nit: long line PS2, Line 406: i missing space ? PS2, Line 407: extra space Line 419: bool IR_NO_INLINE EvalProbeRow( nit: this extra new line seems a bit inconsistent with the rest of the files (e.g. line 432). PS2, Line 425: rows a row ? Line 429: /// 'expr_values_null' Extra new line again. Why not continue the next line here ? PS2, Line 436: nit: extra space PS2, Line 446: IR_ALWAYS_INLINE ALWAYS_INLINE ? -- To view, visit http://gerrit.cloudera.org:8080/4326 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie353666dbb5c958f0094d169306fe930ec3014c5 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
