Michael Ho has posted comments on this change. Change subject: IMPALA-4008: don't bake in hash table and hash join pointers ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4326/2/be/src/exec/hash-table.cc File be/src/exec/hash-table.cc: PS2, Line 317: uint8_t* > The return value has to be const if the input argument is const though. I t I see. Makes sense. -- To view, visit http://gerrit.cloudera.org:8080/4326 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie353666dbb5c958f0094d169306fe930ec3014c5 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes