Michael Ho has posted comments on this change. Change subject: IMPALA-4008: don't bake in hash table and hash join pointers ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4326/2/be/src/exec/hash-table.cc File be/src/exec/hash-table.cc: Line 185: uint32_t HashTableCtx::HashVariableLenRow( > The whitespace decisions were made by clang-format. It does seem a little d Can we configure clang-format to not format the code this way ? I find such inconsistency very annoying but that's just me. PS2, Line 317: uint8_t* > Some of the callsites need it to return a non-const pointer, e.g. EvalRow() Hmm...I think I meant the first argument, not the return value. -- To view, visit http://gerrit.cloudera.org:8080/4326 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie353666dbb5c958f0094d169306fe930ec3014c5 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
