Tim Armstrong has posted comments on this change. Change subject: IMPALA-4008: don't bake in hash table and hash join pointers ......................................................................
Patch Set 2: (12 comments) http://gerrit.cloudera.org:8080/#/c/4326/2/be/src/exec/hash-table.cc File be/src/exec/hash-table.cc: Line 185: uint32_t HashTableCtx::HashVariableLenRow( > nit: this new line seems to make the formatting a bit inconsistent with say The whitespace decisions were made by clang-format. It does seem a little different to what we did elsewhere but seems readable enough - not sure its worth fighting it. PS2, Line 317: uint8_t* > const uint8_t* Some of the callsites need it to return a non-const pointer, e.g. EvalRow(). PS2, Line 322: ExprValueNullPtr( > This function seems to have only one caller (ExprValueNull()) left. I find Done Line 967: return Status( > Wondering why the extra new line here ? clang-format gets a bit funny with string literals. I joined the string literal below so that it fits on 2 lines (the minimum). http://gerrit.cloudera.org:8080/#/c/4326/2/be/src/exec/hash-table.h File be/src/exec/hash-table.h: Line 158: return expr_values_cache_.ExprValuePtr(expr_values_cache_.cur_expr_values(), expr_idx); > nit: long line Done PS2, Line 406: i > missing space ? Done PS2, Line 407: > extra space Done Line 419: bool IR_NO_INLINE EvalProbeRow( > nit: this extra new line seems a bit inconsistent with the rest of the file Done PS2, Line 425: rows > a row ? Done Line 429: /// 'expr_values_null' > Extra new line again. Why not continue the next line here ? Done PS2, Line 436: > nit: extra space Done PS2, Line 446: IR_ALWAYS_INLINE > ALWAYS_INLINE ? Done -- To view, visit http://gerrit.cloudera.org:8080/4326 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie353666dbb5c958f0094d169306fe930ec3014c5 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
