kwin commented on pull request #136:
URL: 
https://github.com/apache/jackrabbit-filevault/pull/136#issuecomment-828965967


   > which other constructor?
   
   
https://github.com/apache/jackrabbit-filevault/blob/7eb85af4e8a1072c1c0a72f90c59d67310d7b102/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/registry/impl/FSPackageRegistry.java#L166
   
   Also lazy loading is not at all implemented correctly. It needs to be done 
IMHO on almost all operations (not only on `packages` and `contains` but also 
all `register` method which should throw exceptions in case of duplicate 
package ids). Lazy loading also requires proper synchronization, as multiple 
methods may be called from different threads. Also bundle activation is not 
deferred by long-running component activators. 
   
   Why do you think that long-running activate() methods in DS are a problem?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to