stoerr commented on a change in pull request #136:
URL:
https://github.com/apache/jackrabbit-filevault/pull/136#discussion_r622772747
##########
File path:
vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/registry/impl/FSInstallState.java
##########
@@ -417,4 +422,84 @@ public WorkspaceFilter getFilter() {
public Properties getProperties() {
return properties;
}
+
+ @Override
+ public int hashCode() {
+ final int prime = 31;
+ int result = 1;
+ result = prime * result + ((dependencies == null) ? 0 :
dependencies.hashCode());
+ result = prime * result + (external ? 1231 : 1237);
+ result = prime * result + ((filePath == null) ? 0 :
filePath.hashCode());
+ result = prime * result + ((filter == null) ? 0 : filter.hashCode());
+ result = prime * result + ((installTime == null) ? 0 :
installTime.hashCode());
+ result = prime * result + ((packageId == null) ? 0 :
packageId.hashCode());
+ result = prime * result + ((properties == null) ? 0 :
properties.hashCode());
+ result = prime * result + (int) (size ^ (size >>> 32));
+ result = prime * result + ((status == null) ? 0 : status.hashCode());
+ result = prime * result + ((subPackages == null) ? 0 :
subPackages.hashCode());
+ return result;
+ }
+
+ @Override
+ public boolean equals(Object obj) {
+ if (this == obj)
+ return true;
+ if (obj == null)
+ return false;
+ if (getClass() != obj.getClass())
+ return false;
+ FSInstallState other = (FSInstallState) obj;
+ if (dependencies == null) {
+ if (other.dependencies != null)
+ return false;
+ } else if (!dependencies.equals(other.dependencies))
+ return false;
+ if (external != other.external)
+ return false;
+ if (filePath == null) {
+ if (other.filePath != null)
+ return false;
+ } else if (!filePath.equals(other.filePath))
+ return false;
+ if (filter == null) {
+ if (other.filter != null)
+ return false;
+ } else if (!filter.equals(other.filter))
+ return false;
+ if (installTime == null) {
+ if (other.installTime != null)
+ return false;
+ } else if (!installTime.equals(other.installTime))
+ return false;
+ if (packageId == null) {
+ if (other.packageId != null)
+ return false;
+ } else if (!packageId.equals(other.packageId))
+ return false;
+ if (properties == null) {
+ if (other.properties != null)
+ return false;
+ } else if (!properties.equals(other.properties))
+ return false;
+ if (size != other.size)
+ return false;
+ if (status != other.status)
+ return false;
+ if (subPackages == null) {
+ if (other.subPackages != null)
+ return false;
+ } else if (!subPackages.equals(other.subPackages))
+ return false;
+ return true;
+ }
+
+ @Override
+ public String toString() {
+ return "FSInstallState [" + (packageId != null ? "packageId=" +
packageId + ", " : "")
Review comment:
Yes! I like it when you're adding toString() wherever it makes sense.
That's often more pleasant in the debugger.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
