stoerr commented on a change in pull request #136:
URL:
https://github.com/apache/jackrabbit-filevault/pull/136#discussion_r622768989
##########
File path:
vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/registry/impl/FSInstallState.java
##########
@@ -417,4 +422,84 @@ public WorkspaceFilter getFilter() {
public Properties getProperties() {
return properties;
}
+
+ @Override
+ public int hashCode() {
+ final int prime = 31;
Review comment:
Just for fun: I always thought using 31 as a factor is a quite bad
choice, as it easily creates conflicts.
https://stackoverflow.com/a/2816747/21499 explains why I think 92821 is much
better when you are using that pattern. :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
