stoerr commented on a change in pull request #136:
URL:
https://github.com/apache/jackrabbit-filevault/pull/136#discussion_r622768174
##########
File path:
vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/registry/impl/FSPackageRegistry.java
##########
@@ -185,6 +182,7 @@ public void activate(BundleContext context, Config config) {
log.info("Jackrabbit Filevault FS Package Registry initialized with
home location {}", this.homeDir.getPath());
this.scope = InstallationScope.valueOf(config.scope());
this.securityConfig = new
AbstractPackageRegistry.SecurityConfig(config.authIdsForHookExecution(),
config.authIdsForRootInstallation());
+ loadPackageCache();
Review comment:
I think doing file system accesses within the OSGI activation is
dangerous - please see my comment
https://github.com/apache/jackrabbit-filevault/pull/136#issuecomment-828974792 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
