smiroslav commented on a change in pull request #510:
URL: https://github.com/apache/jackrabbit-oak/pull/510#discussion_r819444297
##########
File path:
oak-upgrade/src/main/java/org/apache/jackrabbit/oak/upgrade/cli/node/SegmentAzureFactory.java
##########
@@ -87,6 +90,10 @@ public Builder containerName(String containerName) {
this.containerName = containerName;
return this;
}
+ public Builder sasToken(String sasToken) {
Review comment:
Is it necessary to explicitly set ```sasToken```? I have impression that
it can be the part of ```connectionString```.
https://docs.microsoft.com/en-us/azure/storage/common/storage-configure-connection-string#create-a-connection-string-using-a-shared-access-signature
##########
File path:
oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureUtilities.java
##########
@@ -116,6 +116,12 @@ public static CloudBlobDirectory
cloudBlobDirectoryFrom(String connection, Strin
return container.getDirectoryReference(dir);
}
+ public static CloudBlobDirectory cloudBlobDirectoryFromSasUri(String
connection, String containerName,
Review comment:
Not sure this method is needed, since the only difference in this method
compared to ```cloudBlobDirectoryFrom``` is that container creation is skipped.
Otherwise in the method implementation I do not see anything specific to SAS
URI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
