jelmini commented on a change in pull request #510:
URL: https://github.com/apache/jackrabbit-oak/pull/510#discussion_r822555766
##########
File path:
oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureUtilities.java
##########
@@ -116,6 +116,12 @@ public static CloudBlobDirectory
cloudBlobDirectoryFrom(String connection, Strin
return container.getDirectoryReference(dir);
}
+ public static CloudBlobDirectory cloudBlobDirectoryFromSasUri(String
connection, String containerName,
Review comment:
I agree with @smiroslav that this new method is misleading. What do we
need is the ability to skip creating the container. I suggest to add a boolean
parameter `skipCreateContainer` to the existing `cloudBlobDirectoryFrom()`
methods. The value could then come from `MigrationOptions`, so that when
running the upgrade tool, the flag can be set at the command line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
