jelmini commented on a change in pull request #510:
URL: https://github.com/apache/jackrabbit-oak/pull/510#discussion_r832025657
##########
File path:
oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureUtilities.java
##########
@@ -116,6 +116,15 @@ public static CloudBlobDirectory
cloudBlobDirectoryFrom(String connection, Strin
return container.getDirectoryReference(dir);
}
+ public static CloudBlobDirectory cloudBlobDirectoryFrom(String connection,
String containerName,
Review comment:
@smiroslav It's me that suggested to add an overload of
`cloudBlobDirectoryFrom()`, in order to keep backward compatibility in case
3rd-party code is using it. Do you think it's not necessary?
If we keep them, however, one overload should call the second, instead of
re-implementing it:
```java
public static CloudBlobDirectory cloudBlobDirectoryFrom(String connection,
String containerName,
String dir) throws InvalidKeyException, URISyntaxException,
StorageException {
return cloudBlobDirectoryFrom(connection, containerName, dir, false);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
