nit0906 commented on code in PR #715:
URL: https://github.com/apache/jackrabbit-oak/pull/715#discussion_r981910827


##########
oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/writer/IndexWriterUtils.java:
##########
@@ -70,6 +73,10 @@ public static IndexWriterConfig 
getIndexWriterConfig(LuceneIndexDefinition defin
             IndexWriterConfig config = new IndexWriterConfig(VERSION, 
analyzer);
             if (remoteDir) {

Review Comment:
   one reason why remoteDir could be true is because copyOnWrite is disabled 
(which usually isn't the case).
   
   So effectively the new code change here (the else block) will impact normal 
indexing as well (not just the out of the band indexing from oak-run), from 
what I can tell - was that taken into account ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to