nit0906 commented on code in PR #715:
URL: https://github.com/apache/jackrabbit-oak/pull/715#discussion_r982189273
##########
oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/writer/IndexWriterUtils.java:
##########
@@ -70,6 +73,10 @@ public static IndexWriterConfig
getIndexWriterConfig(LuceneIndexDefinition defin
IndexWriterConfig config = new IndexWriterConfig(VERSION,
analyzer);
if (remoteDir) {
config.setMergeScheduler(new SerialMergeScheduler());
+ } else {
Review Comment:
ah - ok. I think it would be difficult to determine here whether this is
being called from out-of-band indexing or redular async indexing. So I think
the best we can do is to set the default to 1 and add a comment that the
default value should be changed only after thorough analysis.
##########
oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/writer/IndexWriterUtils.java:
##########
@@ -70,6 +73,10 @@ public static IndexWriterConfig
getIndexWriterConfig(LuceneIndexDefinition defin
IndexWriterConfig config = new IndexWriterConfig(VERSION,
analyzer);
if (remoteDir) {
config.setMergeScheduler(new SerialMergeScheduler());
+ } else {
Review Comment:
ah - ok. I think it would be difficult to determine here whether this is
being called from out-of-band indexing or regular async indexing. So I think
the best we can do is to set the default to 1 and add a comment that the
default value should be changed only after thorough analysis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
