amit-jain commented on code in PR #715:
URL: https://github.com/apache/jackrabbit-oak/pull/715#discussion_r982096471
##########
oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/writer/IndexWriterUtils.java:
##########
@@ -70,6 +73,10 @@ public static IndexWriterConfig
getIndexWriterConfig(LuceneIndexDefinition defin
IndexWriterConfig config = new IndexWriterConfig(VERSION,
analyzer);
if (remoteDir) {
config.setMergeScheduler(new SerialMergeScheduler());
+ } else {
Review Comment:
I am not sure. Can you suggest what change would be advisable here to ccount
for that. The default is 1 thread so essentially the concurrent will default to
serial ofcourse if the property is not overriden
##########
oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/writer/IndexWriterUtils.java:
##########
@@ -33,12 +35,13 @@
import org.apache.lucene.analysis.Analyzer;
import org.apache.lucene.analysis.miscellaneous.PerFieldAnalyzerWrapper;
import org.apache.lucene.analysis.shingle.ShingleAnalyzerWrapper;
+import org.apache.lucene.index.ConcurrentMergeScheduler;
import org.apache.lucene.index.IndexWriterConfig;
import org.apache.lucene.index.SerialMergeScheduler;
-import static
org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndexConstants.VERSION;
-
public class IndexWriterUtils {
+ private static final int INDEX_WRITER_MAX_MERGE = 8;
Review Comment:
Yes, makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
