nit0906 commented on code in PR #715:
URL: https://github.com/apache/jackrabbit-oak/pull/715#discussion_r982429383
##########
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticBulkProcessorHandler.java:
##########
@@ -151,6 +153,7 @@ private BulkProcessor initBulkProcessor() {
return BulkProcessor.builder(requestConsumer(),
new OakBulkProcessorListener(), this.indexName +
"-bulk-processor")
.setBulkActions(indexDefinition.bulkActions)
+ .setConcurrentRequests(BULK_PROCESSOR_CONCURRENCY)
Review Comment:
@amit-jain - agreed.
the bulkProcessor instance is actually linked to index definition and all
other configurations like bulk size threshold , flush interval etc are also
defined/configured at index definition level. So if we want to keep
configurations in the same line - then it would seem the concurrency can also
go in the index definition.
But this is a different case where we would want to distinguish this on the
basis of whether indexing is running from oak-run or otherwise - so configuring
this in index definition won't be possible (since the index def would remain
the same in both cases but we would want the concurrency to be different - so a
system property is the only solution here.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
