rishabhdaim commented on code in PR #1262:
URL: https://github.com/apache/jackrabbit-oak/pull/1262#discussion_r1448448230
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##########
@@ -1222,6 +1229,29 @@ public void removeGarbage(final VersionGCStats stats) {
timer.reset().start();
try {
+ if (embeddedVerification) {
+ // embedded verification is done completely independent of
DocumentStore
+ // also, it's done irrespective of dry-run or not
+ final Iterator<UpdateOp> it = updateOpList.iterator();
+ while(it.hasNext()) {
+ final UpdateOp update = it.next();
+ NodeDocument oldDoc = ds.find(Collection.NODES,
update.getId());
Review Comment:
I think we should fetch them all in one go. That would be much faster.
Since no such API exists in `DocumentStore`, I suggest we use Mongo APIs
directly here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
