rishabhdaim commented on code in PR #1262:
URL: https://github.com/apache/jackrabbit-oak/pull/1262#discussion_r1448460235
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##########
@@ -1252,6 +1282,37 @@ public void removeGarbage(final VersionGCStats stats) {
delayOnModifications(timer.stop().elapsed(MILLISECONDS),
cancel);
}
}
+
+ private boolean verify(NodeDocument oldDoc, NodeDocument newDoc,
UpdateOp update) {
Review Comment:
This comparison is doing more than required. In case the oldDoc is null, we
should ignore it and move forward cause that is already taken care of by Mongo.
Mongo only updates if it finds the document else, it ignores the update
operation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
