stefan-egli commented on code in PR #1262:
URL: https://github.com/apache/jackrabbit-oak/pull/1262#discussion_r1448728988
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##########
@@ -1222,6 +1229,29 @@ public void removeGarbage(final VersionGCStats stats) {
timer.reset().start();
try {
+ if (embeddedVerification) {
+ // embedded verification is done completely independent of
DocumentStore
+ // also, it's done irrespective of dry-run or not
+ final Iterator<UpdateOp> it = updateOpList.iterator();
+ while(it.hasNext()) {
+ final UpdateOp update = it.next();
+ NodeDocument oldDoc = ds.find(Collection.NODES,
update.getId());
Review Comment:
agree that a bulk `find` would be handy. In this case it would mostly be
reading from the `nodesCache` though, as detailedGC just needed the oldDoc as
well. So it's mostly not going to read from mongo.
What about splitting bulk API into a separate ticket if we see it is
necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
