Github user afs commented on a diff in the pull request:

    https://github.com/apache/jena/pull/57#discussion_r29938061
  
    --- Diff: 
jena-base/src/main/java/org/apache/jena/atlas/lib/CacheFactory.java ---
    @@ -43,7 +43,7 @@
     
         /** One slot cache */
         public static <Key, Value> Cache<Key, Value> createOneSlotCache() {
    -        return new Cache1<>() ;
    +        return new CacheGuava<>(1) ;
         }
    --- End diff --
    
    CacheGuava is a bit heavy for a one-slot cache.  While Cahce1 may not be 
used currently, if it were, then keeping it as simple, small implementation is 
better. Proposal: Keep Cache1 as is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to