Github user afs commented on a diff in the pull request:

    https://github.com/apache/jena/pull/57#discussion_r29938974
  
    --- Diff: 
jena-base/src/main/java/org/apache/jena/atlas/lib/CacheFactory.java ---
    @@ -43,7 +43,7 @@
     
         /** One slot cache */
         public static <Key, Value> Cache<Key, Value> createOneSlotCache() {
    -        return new Cache1<>() ;
    +        return new CacheGuava<>(1) ;
         }
    --- End diff --
    
    It's not used (if it is used elsewhere, then as it's not API, reasonable 
change is OK). The cache interface is useful though and `Supplier` does not 
cover the `getOrFill` pattern.  It also allows a switch from `Cache1` to a 
bigger, better cache as the interface is the same.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to