Github user ajs6f commented on a diff in the pull request:

    https://github.com/apache/jena/pull/57#discussion_r29938434
  
    --- Diff: 
jena-base/src/main/java/org/apache/jena/atlas/lib/CacheFactory.java ---
    @@ -43,7 +43,7 @@
     
         /** One slot cache */
         public static <Key, Value> Cache<Key, Value> createOneSlotCache() {
    -        return new Cache1<>() ;
    +        return new CacheGuava<>(1) ;
         }
    --- End diff --
    
    Shall I check and see whether `Cache1` is really in use? It tastes to me 
like memoization, which might be better supplied by some other means in Java 8, 
e.g via statics that use 
[Supplier](http://docs.oracle.com/javase/8/docs/api/java/util/function/Supplier.html).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to