Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/57#discussion_r29938565
--- Diff:
jena-base/src/main/java/org/apache/jena/atlas/lib/cache/CacheSimple.java ---
@@ -37,120 +37,81 @@
public class CacheSimple<K,V> implements Cache<K,V>
{
- private final V[] values ;
- private final K[] keys ;
- private final int size ;
- private int currentSize = 0 ;
- private BiConsumer<K,V> dropHandler = null ;
+ private Map<K,V> internalCache;
+
--- End diff --
A Map grows as more, different, keys are added whereas the existing
CacheSimple is a fixed size slot replacement cache with the property that it
never resizes.
CacheSimple is a fast cache, traded against a poorer than LRU
replacement/eviction policy of same-hash slot replacement. Using a Map changes
its characteristics.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
