Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/57#discussion_r29957586
--- Diff:
jena-tdb/src/main/java/org/apache/jena/tdb/base/block/BlockMgrCache.java ---
@@ -58,10 +58,7 @@ private BlockMgrCache(int readSlots, int writeSlots,
final BlockMgr blockMgr)
{
--- End diff --
No problem. It was definitely to avoid `null`-checking, because
`BlockMgrCache` sprouted all kinds of `null`-checks when I killed `Cache0`. As
I commented there, I would like to rewrite `BlockMgrCache` to use `Optional`
but I'm not yet confident enough that I understand it well enough, and I'm not
yet familiar enough with the test framework to understand how well-covered
`BlockMgrCache` is and how careful I need to be around it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
